Flashgot + Open in browser make ok/cancel off

Bug reports and enhancement requests
Post Reply
sherpya
Posts: 1
Joined: Mon Apr 11, 2011 3:01 am

Flashgot + Open in browser make ok/cancel off

Post by sherpya » Mon Apr 11, 2011 3:10 am

I'm using flashgot and open in browser extensions, both add a select box in download dialog, but since it is not re-sizable I get yes/cancel button off by half.
It's not directly a flashgot issue, but if I get another extension that adds something to dialog bog I'll lose buttons at all :)

I don't known if an extension can change the download size

here a screenshot
Image
Mozilla/5.0 (Windows NT 5.2; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0
Top
User avatar
therube
Ambassador
Posts: 7248
Joined: Thu Mar 19, 2009 4:17 pm
Location: Maryland USA

Re: Flashgot + Open in browser make ok/cancel off

Post by therube » Tue Apr 12, 2011 3:14 pm

Wonder if some CSS in userChrome.css couldn't enlarge the dialog box?
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 Pinball NoScript FlashGot AdblockPlus
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.18) Gecko/20110320 SeaMonkey/2.0.13
Top
alexo
Junior Member
Posts: 23
Joined: Fri Nov 27, 2009 5:58 pm

Re: Flashgot + Open in browser make ok/cancel off

Post by alexo » Wed Mar 04, 2015 5:40 pm

Sorry to resurrect this thread, but 4 years after the problem was reported, it still exists.

Image

Also, please see https://github.com/spasche/openinbrowser/issues/6 :

Ok, I can reproduce if I only keep FlashGot and Open in Browser.

Apparently the dialog adapts to the content, but sometimes it is not tall enough. FlashGot doesn't seem to set the height explicitly. I don't know why the dialog isn't auto-sized properly, maybe that's because some elements are added dynamically after the dialog is rendered.


Please fix.

Thank you!
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0
Top
flashgot.user
Junior Member
Posts: 27
Joined: Thu Sep 11, 2014 9:47 am

Re: Flashgot + Open in browser make ok/cancel off

Post by flashgot.user » Wed Mar 04, 2015 7:48 pm

I don't know why simply calling sizeToContent() wasn't enough, so I'm not sure this patch won't break something.

Code: Select all

http://rghost.net/private/85DnSN4kR/f65477b3edc728ae9064d44df8f88d04
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 SeaMonkey/2.25
Top
User avatar
Giorgio Maone
Site Admin
Posts: 8654
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:
Contact Giorgio Maone

Re: Flashgot + Open in browser make ok/cancel off

Post by Giorgio Maone » Wed Mar 04, 2015 9:07 pm

flashgot.user wrote:I don't know why simply calling sizeToContent() wasn't enough, so I'm not sure this patch won't break something.

Code: Select all

http://rghost.net/private/85DnSN4kR/f65477b3edc728ae9064d44df8f88d04

Checking it, thank you.
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0
Top
alexo
Junior Member
Posts: 23
Joined: Fri Nov 27, 2009 5:58 pm

Re: Flashgot + Open in browser make ok/cancel off

Post by alexo » Sat Mar 21, 2015 2:56 pm

Any news?
The problem is still happening as of 1.5.6.11
Mozilla/5.0 (Windows NT 5.1; rv:36.0) Gecko/20100101 Firefox/36.0
Top
alexo
Junior Member
Posts: 23
Joined: Fri Nov 27, 2009 5:58 pm

Re: Flashgot + Open in browser make ok/cancel off

Post by alexo » Sat Apr 18, 2015 2:39 pm

Anything?
Mozilla/5.0 (Windows NT 5.1; rv:37.0) Gecko/20100101 Firefox/37.0
Top
alexo
Junior Member
Posts: 23
Joined: Fri Nov 27, 2009 5:58 pm

Re: Flashgot + Open in browser make ok/cancel off

Post by alexo » Fri Jun 19, 2015 3:23 am

The original problem report was posted 4 years ago.
A suggested fix was posted 3 months ago, and "checked" afterwards.
Any news?
Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Firefox/38.0
Top
User avatar
Thrawn
Senior Member
Posts: 3106
Joined: Mon Jan 16, 2012 3:46 am
Location: Australia
Contact:
Contact Thrawn

Re: Flashgot + Open in browser make ok/cancel off

Post by Thrawn » Fri Jun 19, 2015 4:24 am

It's on Giorgio's to-do list. How high, I'm not sure.
======
Thrawn
------------
Religion is not the opium of the masses. Daily life is the opium of the masses.

True religion, which dares to acknowledge death and challenge the way we live, is an attempt to wake up.
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0
Top
alexo
Junior Member
Posts: 23
Joined: Fri Nov 27, 2009 5:58 pm

Re: Flashgot + Open in browser make ok/cancel off

Post by alexo » Sun Mar 20, 2016 2:28 am

The problem was fixed for some time but reappeared again several days ago.
Is this a regression?

Thanks.
Mozilla/5.0 (Windows NT 5.1; rv:45.0) Gecko/20100101 Firefox/45.0
Top
alexo
Junior Member
Posts: 23
Joined: Fri Nov 27, 2009 5:58 pm

Re: Flashgot + Open in browser make ok/cancel off

Post by alexo » Thu Jan 12, 2017 12:23 am

The problem is still happening.
Can anyone look at it?
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Top
alexo
Junior Member
Posts: 23
Joined: Fri Nov 27, 2009 5:58 pm

Re: Flashgot + Open in browser make ok/cancel off

Post by alexo » Mon Aug 14, 2017 2:56 pm

Problem happens again after upgrade to 55.0.1
Please take a look at it.
Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
Top
Post Reply

Return to “FlashGot Development”