[FIXED] FG+NoScript downloads all detected Youtube streams

Bug reports and enhancement requests
Observer09
Posts: 5
Joined: Wed Sep 11, 2013 9:54 am

Re: Conflict with NoScript resulting Youtube odd behaviour

Post by Observer09 » Thu Sep 12, 2013 1:22 pm

@Thrawn
Yup, it's related.

@Giorgio
It's disappear after disabling NoScript's ABE .
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:20.3) Gecko/20130809 Firefox/20.3 PaleMoon/20.3-x64

al_9x
Master Bug Buster
Posts: 931
Joined: Thu Mar 19, 2009 4:52 pm

Re: FG downloads all detected streams for youtube videos

Post by al_9x » Thu Sep 12, 2013 1:48 pm

Giorgio Maone wrote:Poll:
  • are you all using NoScript too?
  • Does disabling NoScript Options|Advanced|ABE make the problem disappear?
Asking because it might be a conflict between the new signature sniffing code and NoScript's load deferral/redirection machinery.


yes to both
Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20100101 Firefox/17.0

galgamesh
Posts: 2
Joined: Tue Aug 14, 2012 5:21 pm

Re: Conflict with NoScript resulting Youtube odd behaviour

Post by galgamesh » Fri Sep 13, 2013 6:25 am

I can also confirm that the issue is related to NoScript, the problem goes away after disabling ABE in NoScript.

Took me a while to narrow down why my bandwidth was still active even though I wasn't downloading anything, thought I had a virus at first.

Hope it gets fixed soon.
Mozilla/5.0 (Windows NT 5.1; rv:23.0) Gecko/20100101 Firefox/23.0

User avatar
Giorgio Maone
Site Admin
Posts: 8697
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: Conflict with NoScript resulting Youtube odd behaviour

Post by Giorgio Maone » Sat Sep 14, 2013 10:08 pm

Please check whether the problem persist in latest development build 1.5.5.9rc1.
If it does, please include in your report detailed step-by-step instruction to consistently reproduce AND observe the extra downloads, thank you.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20100101 Firefox/23.0

al_9x
Master Bug Buster
Posts: 931
Joined: Thu Mar 19, 2009 4:52 pm

Re: FG downloads all detected streams for youtube videos

Post by al_9x » Sun Sep 15, 2013 1:56 am

Does 1.5.5.9rc1 have a fix for this? The changelog does not appear to mention it.

Is there an option to disable speculative requests and only do it on demand?
Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20100101 Firefox/17.0

User avatar
Giorgio Maone
Site Admin
Posts: 8697
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: FG downloads all detected streams for youtube videos

Post by Giorgio Maone » Sun Sep 15, 2013 5:39 am

al_9x wrote:Does 1.5.5.9rc1 have a fix for this?

Maybe, tentatively (that's why it's not mentioned in the changelog), because I couldn't actually reproduce.
al_9x wrote:Is there an option to disable speculative requests and only do it on demand?

I'm not sure about the "speculative requests" you want to block, but the flashgot.media.YouTube.autodetect preference disables any Youtube parsing attempt.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20100101 Firefox/23.0

al_9x
Master Bug Buster
Posts: 931
Joined: Thu Mar 19, 2009 4:52 pm

Re: FG downloads all detected streams for youtube videos

Post by al_9x » Sun Sep 15, 2013 6:04 am

Giorgio Maone wrote:
al_9x wrote:Does 1.5.5.9rc1 have a fix for this?

Maybe, tentatively (that's why it's not mentioned in the changelog), because I couldn't actually reproduce.
al_9x wrote:Is there an option to disable speculative requests and only do it on demand?

I'm not sure about the "speculative requests" you want to block, but the flashgot.media.YouTube.autodetect preference disables any Youtube parsing attempt.


"speculative" is typically used to describe unsolicited pre-fetch dns/http requests. Such things should be optional. What do you mean by "parsing"? If it means turning off media url detection from existing page, that's going too far. The idea is for any additional connections to be done only on demand when the user indicates via the ui the intent to download.
Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20100101 Firefox/17.0

al_9x
Master Bug Buster
Posts: 931
Joined: Thu Mar 19, 2009 4:52 pm

Re: FG downloads all detected streams for youtube videos

Post by al_9x » Sun Sep 15, 2013 6:17 am

problem still present in 1.5.5.9rc1

xp sp3, Fx 23.0.1, new profile + FG + NS, block flash on trusted

does not happen always, to repro I open http://www.youtube.com/user/Google/videos and open videos in new tabs until it happens, ~3 attempts
Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20100101 Firefox/17.0

User avatar
Giorgio Maone
Site Admin
Posts: 8697
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: FG downloads all detected streams for youtube videos

Post by Giorgio Maone » Sun Sep 15, 2013 6:25 am

al_9x wrote:
Giorgio Maone wrote:
al_9x wrote:Does 1.5.5.9rc1 have a fix for this?

Maybe, tentatively (that's why it's not mentioned in the changelog), because I couldn't actually reproduce.
al_9x wrote:Is there an option to disable speculative requests and only do it on demand?

I'm not sure about the "speculative requests" you want to block, but the flashgot.media.YouTube.autodetect preference disables any Youtube parsing attempt.


"speculative" is typically used to describe unsolicited pre-fetch dns/http requests.

FlashGot doesn't prefetch anything (intentionally, at least).
The extra requests are the bae minimum needed to build and show the FlashGot Media UI in the very specific and complex Youtube case.
On a side note, could you tell me whether the issue this topic is about seems to be fixed, or otherwise give me a reproducible minimal test case?
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20100101 Firefox/23.0

al_9x
Master Bug Buster
Posts: 931
Joined: Thu Mar 19, 2009 4:52 pm

Re: FG downloads all detected streams for youtube videos

Post by al_9x » Sun Sep 15, 2013 6:41 am

There's an additional problem I noticed which started with Fg 1.5.5.7 and is still present with 1.5.5.9rc1, occasionally, as I am opening background video tabs (one at a time), one ends up without a placeholder, just has a black rectangle.

When (and only when) this happens the following error is logged

Code: Select all

Timestamp: 9/15/2013 2:35:59 AM
Error: TypeError: can't convert ytplayer.config.args[key] to string
Source File: http://www.youtube.com/watch?v=nfKZ5BL6OGo
Line: 120



here's the code on the page that fails:

Code: Select all

        for (var key in ytplayer.config.args) {
          encoded.push(encodeURIComponent(key) + '=' + encodeURIComponent(ytplayer.config.args[key]));
        }
Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20100101 Firefox/17.0

al_9x
Master Bug Buster
Posts: 931
Joined: Thu Mar 19, 2009 4:52 pm

Re: FG downloads all detected streams for youtube videos

Post by al_9x » Sun Sep 15, 2013 6:48 am

Giorgio Maone wrote:The extra requests are the bae minimum needed to build and show the FlashGot Media UI in the very specific and complex Youtube case.


These extra requests are what I am referring to. They should be done (optionally) only on demand. If one does not intend to download the video, they are not necessary and so should be optional

Giorgio Maone wrote:On a side note, could you tell me whether the issue this topic is about seems to be fixed, or otherwise give me a reproducible minimal test case?


I already did, previous message: viewtopic.php?f=11&t=16970&start=15#p59269
Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20100101 Firefox/17.0

galgamesh
Posts: 2
Joined: Tue Aug 14, 2012 5:21 pm

Re: Conflict with NoScript resulting Youtube odd behaviour

Post by galgamesh » Sun Sep 15, 2013 6:52 am

Sadly for me the issue continues with the devbuild.

Ok so I have a very basic setup.
I created a new Firefox profile with just Flashgot v 1.5.5.9rc1 and Noscript 2.6.7.1, nothing else.

I'm using Firefox 23.0.1

I notice the issue only when I play a Youtube video, (can't tell you if it happens with any other video site.)

I go to Youtube, play any video and instantly notice a low buffering speed, I get annoyed and navigate away from the video to the home page or any other site, but my internet keeps downloading at full speed.

I have a bandwidth monitor software called Networx that shows my download speed taking my whole bandwidth. I guess it helps that I have only 1Mbps so a drop in speed is more noticeable. At this point if I try to download anything it downloads at half or third my speed.

The issue stops only when I restart or close my browser. And starts again when I play a Youtube video.

And as I mentioned if I disable ABE in NoScript the issue stops altogether.

Hope this helps.
Mozilla/5.0 (Windows NT 5.1; rv:23.0) Gecko/20100101 Firefox/23.0

Hecuba's daughter
Senior Member
Posts: 93
Joined: Mon Oct 01, 2012 6:34 am

Re: FG downloads all detected streams for youtube videos

Post by Hecuba's daughter » Sun Sep 15, 2013 1:46 pm

Your spam filter won't allow a detailed report from me.
I've pmd it.

summary: the latest dev version hasn't stopped the bad behaviour in some but not all youtube videos.

EDIT: used FG latest development version and NS latest development version as at about an hour ago.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20100101 Firefox/17.0

Observer09
Posts: 5
Joined: Wed Sep 11, 2013 9:54 am

Re: Conflict with NoScript resulting Youtube odd behaviour

Post by Observer09 » Sun Sep 15, 2013 7:21 pm

Same result here as described by galgamesh.

Using Palemoon 24 and Firefox 23.01, new profile, only with Flashgot 1.5.5.9rc1 and NoScript 2.6.7.1. Checking bandwidth using Network Meter gadget.
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:24.0) Gecko/20130911 Firefox/24.0 PaleMoon/24.0

al_9x
Master Bug Buster
Posts: 931
Joined: Thu Mar 19, 2009 4:52 pm

Re: Conflict with NoScript resulting Youtube odd behaviour

Post by al_9x » Sun Sep 15, 2013 8:09 pm

Observer09, this is the original thread on this bug: viewtopic.php?f=11&t=16970

Unless what you're reporting is different (doesn't seem to be), it would make sense to keep it in one thread.
Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20100101 Firefox/17.0

Post Reply