Page 1 of 1

1 Line of Code Breaking K-Meleon Compatibility

Posted: Thu Jan 20, 2011 7:07 am
by jk-
There is a single line of code in Main.js which prevents compatibility with K-Meleon.
Line # 1944

Code: Select all

  geckoVersion: ("nsIXULAppInfo" in  CI) ? CC["@mozilla.org/xre/app-info;1"].getService(CI.nsIXULAppInfo).platformVersion : "0.0",


"mozilla.org/xre/app-info" isn't available in current K-Meleon.

Commenting out this line of code or replacing it with "geckoVersion:"0.0"" allows NoScript to work in KM without any other code modifications.


-jk

Re: 1 Line of Code Breaking K-Meleon Compatibility

Posted: Thu Jan 20, 2011 8:05 am
by Giorgio Maone
Thank you, it will be changed into

Code: Select all

geckoVersion: ("@mozilla.org/xre/app-info;1" in  CC) ? CC["@mozilla.org/xre/app-info;1"].getService(CI.nsIXULAppInfo).platformVersion : "0.0",

in next dev build.

Re: 1 Line of Code Breaking K-Meleon Compatibility

Posted: Thu Jan 20, 2011 8:27 am
by jk-
Thanks a lot Giorgio, I'm sure all the K-Meleon users will be pleased!

-jk

Re: 1 Line of Code Breaking K-Meleon Compatibility

Posted: Sun Jan 23, 2011 10:05 pm
by Giorgio Maone
Done, please check latest development build.

Re: 1 Line of Code Breaking K-Meleon Compatibility

Posted: Sun Jan 23, 2011 11:18 pm
by jk-
Unfortunately a new complication has arisen 2.0.9.7rc1. The new doctype definitions in the XULs aren't compatible.

old code:

Code: Select all

<!DOCTYPE dialog [
<!ENTITY % noscript SYSTEM "chrome://noscript/locale/noscript.dtd" >
%noscript;
<!ENTITY % noscriptFB  SYSTEM "chrome://noscript/content/en-US/noscript.dtd" >
%noscriptFB;
]
>


new code that doesn't work:

Code: Select all

<!DOCTYPE dialog SYSTEM "chrome://noscript/locale/noscript.dtd">

Re: 1 Line of Code Breaking K-Meleon Compatibility

Posted: Mon Jan 24, 2011 1:46 am
by jk-
After further testing, there are other XUL incompatibilities in 2.0.9.7rc1. I will try to isolate the exact issues.

Re: 1 Line of Code Breaking K-Meleon Compatibility

Posted: Mon Jan 24, 2011 7:45 am
by Giorgio Maone
jk- wrote:After further testing, there are other XUL incompatibilities in 2.0.9.7rc1. I will try to isolate the exact issues.

Please do it. If they're a reasonable subset, I could setup a packaging script making the changes on the fly to keep K-Meleon builds in sync.


BTW, does the DTD problem above mean that previous NoScript versions used to work on KM but always in English, no matter what the browser's language was?

Re: 1 Line of Code Breaking K-Meleon Compatibility

Posted: Tue Jan 25, 2011 1:19 am
by jk-
Giorgio Maone wrote:
jk- wrote:After further testing, there are other XUL incompatibilities in 2.0.9.7rc1. I will try to isolate the exact issues.

Please do it. If they're a reasonable subset, I could setup a packaging script making the changes on the fly to keep K-Meleon builds in sync.

OK,I'll let you know.

BTW, does the DTD problem above mean that previous NoScript versions used to work on KM but always in English, no matter what the browser's language was?


This question I'll have to pose to the K-Meleon user-base as I have only tried it in English.


I should mention, your fix for the original problem with Main.js does work fine.

-jk

Re: 1 Line of Code Breaking K-Meleon Compatibility

Posted: Wed Jan 26, 2011 11:32 pm
by 4td8s
jk- wrote:Unfortunately a new complication has arisen 2.0.9.7rc1. The new doctype definitions in the XULs aren't compatible.

old code:

Code: Select all

<!DOCTYPE dialog [
<!ENTITY % noscript SYSTEM "chrome://noscript/locale/noscript.dtd" >
%noscript;
<!ENTITY % noscriptFB  SYSTEM "chrome://noscript/content/en-US/noscript.dtd" >
%noscriptFB;
]
>


new code that doesn't work:

Code: Select all

<!DOCTYPE dialog SYSTEM "chrome://noscript/locale/noscript.dtd">


read my latest post in this K-meleon forum thread.
the new doctype definitions problem also occurs with latest stable version of noscript which is version 2.0.9.6.

Re: 1 Line of Code Breaking K-Meleon Compatibility

Posted: Sun Mar 27, 2011 3:22 am
by 4td8s
...still waiting for jk- to fix the problem for k-meleon. noscript 2.1 for firefox & seamonkey is already out now.