1 Line of Code Breaking K-Meleon Compatibility

Bug reports and enhancement requests
Post Reply
jk-
Posts: 5
Joined: Thu Jan 20, 2011 6:50 am
Location: The United States of America
Contact:

1 Line of Code Breaking K-Meleon Compatibility

Post by jk- » Thu Jan 20, 2011 7:07 am

There is a single line of code in Main.js which prevents compatibility with K-Meleon.
Line # 1944

Code: Select all

  geckoVersion: ("nsIXULAppInfo" in  CI) ? CC["@mozilla.org/xre/app-info;1"].getService(CI.nsIXULAppInfo).platformVersion : "0.0",


"mozilla.org/xre/app-info" isn't available in current K-Meleon.

Commenting out this line of code or replacing it with "geckoVersion:"0.0"" allows NoScript to work in KM without any other code modifications.


-jk
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.17pre) Gecko K-Meleon/1.6.0

User avatar
Giorgio Maone
Site Admin
Posts: 8715
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: 1 Line of Code Breaking K-Meleon Compatibility

Post by Giorgio Maone » Thu Jan 20, 2011 8:05 am

Thank you, it will be changed into

Code: Select all

geckoVersion: ("@mozilla.org/xre/app-info;1" in  CC) ? CC["@mozilla.org/xre/app-info;1"].getService(CI.nsIXULAppInfo).platformVersion : "0.0",

in next dev build.
Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.2.13) Gecko/20101203 Firefox/3.6.13

jk-
Posts: 5
Joined: Thu Jan 20, 2011 6:50 am
Location: The United States of America
Contact:

Re: 1 Line of Code Breaking K-Meleon Compatibility

Post by jk- » Thu Jan 20, 2011 8:27 am

Thanks a lot Giorgio, I'm sure all the K-Meleon users will be pleased!

-jk
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.17pre) Gecko K-Meleon/1.6.0

User avatar
Giorgio Maone
Site Admin
Posts: 8715
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: 1 Line of Code Breaking K-Meleon Compatibility

Post by Giorgio Maone » Sun Jan 23, 2011 10:05 pm

Done, please check latest development build.
Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.2.13) Gecko/20101203 Firefox/3.6.13

jk-
Posts: 5
Joined: Thu Jan 20, 2011 6:50 am
Location: The United States of America
Contact:

Re: 1 Line of Code Breaking K-Meleon Compatibility

Post by jk- » Sun Jan 23, 2011 11:18 pm

Unfortunately a new complication has arisen 2.0.9.7rc1. The new doctype definitions in the XULs aren't compatible.

old code:

Code: Select all

<!DOCTYPE dialog [
<!ENTITY % noscript SYSTEM "chrome://noscript/locale/noscript.dtd" >
%noscript;
<!ENTITY % noscriptFB  SYSTEM "chrome://noscript/content/en-US/noscript.dtd" >
%noscriptFB;
]
>


new code that doesn't work:

Code: Select all

<!DOCTYPE dialog SYSTEM "chrome://noscript/locale/noscript.dtd">
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.17pre) Gecko K-Meleon/1.6.0

jk-
Posts: 5
Joined: Thu Jan 20, 2011 6:50 am
Location: The United States of America
Contact:

Re: 1 Line of Code Breaking K-Meleon Compatibility

Post by jk- » Mon Jan 24, 2011 1:46 am

After further testing, there are other XUL incompatibilities in 2.0.9.7rc1. I will try to isolate the exact issues.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.17pre) Gecko K-Meleon/1.6.0

User avatar
Giorgio Maone
Site Admin
Posts: 8715
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: 1 Line of Code Breaking K-Meleon Compatibility

Post by Giorgio Maone » Mon Jan 24, 2011 7:45 am

jk- wrote:After further testing, there are other XUL incompatibilities in 2.0.9.7rc1. I will try to isolate the exact issues.

Please do it. If they're a reasonable subset, I could setup a packaging script making the changes on the fly to keep K-Meleon builds in sync.


BTW, does the DTD problem above mean that previous NoScript versions used to work on KM but always in English, no matter what the browser's language was?
Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.2.13) Gecko/20101203 Firefox/3.6.13

jk-
Posts: 5
Joined: Thu Jan 20, 2011 6:50 am
Location: The United States of America
Contact:

Re: 1 Line of Code Breaking K-Meleon Compatibility

Post by jk- » Tue Jan 25, 2011 1:19 am

Giorgio Maone wrote:
jk- wrote:After further testing, there are other XUL incompatibilities in 2.0.9.7rc1. I will try to isolate the exact issues.

Please do it. If they're a reasonable subset, I could setup a packaging script making the changes on the fly to keep K-Meleon builds in sync.

OK,I'll let you know.

BTW, does the DTD problem above mean that previous NoScript versions used to work on KM but always in English, no matter what the browser's language was?


This question I'll have to pose to the K-Meleon user-base as I have only tried it in English.


I should mention, your fix for the original problem with Main.js does work fine.

-jk
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.17pre) Gecko K-Meleon/1.6.0

4td8s
Junior Member
Posts: 22
Joined: Thu Jun 03, 2010 10:40 pm

Re: 1 Line of Code Breaking K-Meleon Compatibility

Post by 4td8s » Wed Jan 26, 2011 11:32 pm

jk- wrote:Unfortunately a new complication has arisen 2.0.9.7rc1. The new doctype definitions in the XULs aren't compatible.

old code:

Code: Select all

<!DOCTYPE dialog [
<!ENTITY % noscript SYSTEM "chrome://noscript/locale/noscript.dtd" >
%noscript;
<!ENTITY % noscriptFB  SYSTEM "chrome://noscript/content/en-US/noscript.dtd" >
%noscriptFB;
]
>


new code that doesn't work:

Code: Select all

<!DOCTYPE dialog SYSTEM "chrome://noscript/locale/noscript.dtd">


read my latest post in this K-meleon forum thread.
the new doctype definitions problem also occurs with latest stable version of noscript which is version 2.0.9.6.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.16) Gecko/20101130 Firefox/3.5.16

4td8s
Junior Member
Posts: 22
Joined: Thu Jun 03, 2010 10:40 pm

Re: 1 Line of Code Breaking K-Meleon Compatibility

Post by 4td8s » Sun Mar 27, 2011 3:22 am

...still waiting for jk- to fix the problem for k-meleon. noscript 2.1 for firefox & seamonkey is already out now.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.16) Gecko/20101130 Firefox/3.5.16

Post Reply