NoScript takes up over 100% of CPU

Bug reports and enhancement requests
ptheborg
Posts: 5
Joined: Sat Jul 17, 2021 1:30 pm

Re: NoScript takes up over 100% of CPU

Post by ptheborg »

Giorgio Maone wrote: Wed Jul 21, 2021 10:30 pm Everybody here, please check https://github.com/hackademix/noscript/ ... -884539982

Thanks!
Has this been merged to master yet?
The release of noscript 11.2.10 still has the same issue for me
However, the unpacked 11.2.10rc1 fixed it for me
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.1.2 Safari/605.1.15
User avatar
Giorgio Maone
Site Admin
Posts: 9454
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: NoScript takes up over 100% of CPU

Post by Giorgio Maone »

11.2. 10 is identical to 11.2.10rc1, except for the version number.
Mozilla/5.0 (Android 11; Mobile; rv:90.0) Gecko/90.0 Firefox/90.0
ptheborg
Posts: 5
Joined: Sat Jul 17, 2021 1:30 pm

Re: NoScript takes up over 100% of CPU

Post by ptheborg »

Giorgio Maone wrote: Mon Jul 26, 2021 7:22 pm 11.2. 10 is identical to 11.2.10rc1, except for the version number.
OK I have tested the 11.2. 10 and 11.2.10rc1 again and now I am sure, the CPU spike is still not fixed.
I have opened the background page of both versions and I can see like thousands of errors occurring which causes the CPU spike it seems.
DocStartInjection.js
if (attempts % 1000 === 0) {
console.error(`DocStartInjection at $What is the address(es), or URL(s), where this occurs? ${attempts} failed attempts so far...`);
}
This error gets logged to the console. It occurs when downloading files.
Please tell me, how can I help you with debugging this?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.107 Safari/537.36
User avatar
Giorgio Maone
Site Admin
Posts: 9454
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: NoScript takes up over 100% of CPU

Post by Giorgio Maone »

ptheborg wrote: Tue Jul 27, 2021 8:18 am It occurs when downloading files.
OK, I can see it, and it's slightly different from the original issue, where the CPU spike lasted until the tab was closed, which appears to be fixed in 11.2.10.
This one happens only while downloading files, i.e. if you click on an automatically downloadable link (not using "Save as" or other methods), and it stops as soon as the download is finished or canceled.
Working on it, thank you.
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0
User avatar
Giorgio Maone
Site Admin
Posts: 9454
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: NoScript takes up over 100% of CPU

Post by Giorgio Maone »

Please check 11.2.11rc1 (unpacked).
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0
ptheborg
Posts: 5
Joined: Sat Jul 17, 2021 1:30 pm

Re: NoScript takes up over 100% of CPU

Post by ptheborg »

Fantastic! You are so quick with fixing, it works like a charm.
I checked with the background page open and no looping errors occurring so the CPU usages stays low.
Thanks a lot!
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.107 Safari/537.36
Post Reply