[Fixed] 11.2.5rc3 messes up ghacks layout

Bug reports and enhancement requests
Post Reply
barbaz
Senior Member
Posts: 9908
Joined: Sat Aug 03, 2013 5:45 pm

[Fixed] 11.2.5rc3 messes up ghacks layout

Post by barbaz » Thu Apr 29, 2021 2:10 am

Like the title says. https://www.ghacks.net/latest-posts/ is supposed to load in a multi-column format. With 11.2.5rc3 it instead loads in a single, full-width column, and the links are missing almost all styling.

Downgrading NoScript to 11.2.5rc2 and the site has correct styling.
*Always* check the changelogs BEFORE updating that important software!
-

User avatar
therube
Ambassador
Posts: 7698
Joined: Thu Mar 19, 2009 4:17 pm
Location: Maryland USA

Re: 11.2.5rc3 messes up ghacks layout

Post by therube » Fri Apr 30, 2021 4:52 pm

(Confirmed. FF 78.10.0, 11.2.5rc3.)
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 Pinball NoScript FlashGot AdblockPlus
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 SeaMonkey/2.53.7.1

barbaz
Senior Member
Posts: 9908
Joined: Sat Aug 03, 2013 5:45 pm

Re: 11.2.5rc3 messes up ghacks layout

Post by barbaz » Sat May 01, 2021 9:59 pm

I think the culprit is https://github.com/hackademix/noscript/ ... e641b7ca49

Creating a NoScript 11.2.5rc3 xpi with that commit reverted, and from a clean nscl revision d9e20fdcb805f226d795c0068e68563c8dfeea39, this problem does not exist.
*Always* check the changelogs BEFORE updating that important software!
-

User avatar
Giorgio Maone
Site Admin
Posts: 9089
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: 11.2.5rc3 messes up ghacks layout

Post by Giorgio Maone » Sun May 02, 2021 7:48 pm

Should be fixed in latest development build, thanks.
v 11.2.5rc4
============================================================
x Fixed regression in NOSCRIPT emulation (thanks barbaz for
reporting)
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:89.0) Gecko/20100101 Firefox/89.0

barbaz
Senior Member
Posts: 9908
Joined: Sat Aug 03, 2013 5:45 pm

Re: 11.2.5rc3 messes up ghacks layout

Post by barbaz » Sun May 02, 2021 8:22 pm

Confirmed fixed in 11.2.5rc4, thanks! Image
*Always* check the changelogs BEFORE updating that important software!
-

skriptimaahinen
Senior Member
Posts: 232
Joined: Wed Jan 10, 2018 7:37 am

Re: [Fixed] 11.2.5rc3 messes up ghacks layout

Post by skriptimaahinen » Mon May 03, 2021 11:04 am

Unless I'm completely mistaken, running querySelector in MutationObserver callback is likely not going to do what you hope it does as the nodes are quite not yet added to the DOM. You need to check the records.
Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Firefox/78.0

User avatar
Giorgio Maone
Site Admin
Posts: 9089
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: [Fixed] 11.2.5rc3 messes up ghacks layout

Post by Giorgio Maone » Mon May 03, 2021 2:22 pm

skriptimaahinen wrote:
Mon May 03, 2021 11:04 am
Unless I'm completely mistaken
Yes, you are, once in a while :)
MutationObserver callbacks are called after the DOM is modified (but before most side effects of that modification, like repaints or script parsing and execution, happen).
In facts if you don't like the change you cannot prevent it, but you can revert it. And that's also the reason why you can request for (attribute|characterData)OldValue is supported.
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:89.0) Gecko/20100101 Firefox/89.0

skriptimaahinen
Senior Member
Posts: 232
Joined: Wed Jan 10, 2018 7:37 am

Re: [Fixed] 11.2.5rc3 messes up ghacks layout

Post by skriptimaahinen » Tue May 04, 2021 6:40 am

No idea why I thought that was the case. Should always check before I open my mouth. :oops:
Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Firefox/78.0

Post Reply