Page 1 of 1

[Fixed] 11.2.5rc3 messes up ghacks layout

Posted: Thu Apr 29, 2021 2:10 am
by barbaz
Like the title says. https://www.ghacks.net/latest-posts/ is supposed to load in a multi-column format. With 11.2.5rc3 it instead loads in a single, full-width column, and the links are missing almost all styling.

Downgrading NoScript to 11.2.5rc2 and the site has correct styling.

Re: 11.2.5rc3 messes up ghacks layout

Posted: Fri Apr 30, 2021 4:52 pm
by therube
(Confirmed. FF 78.10.0, 11.2.5rc3.)

Re: 11.2.5rc3 messes up ghacks layout

Posted: Sat May 01, 2021 9:59 pm
by barbaz
I think the culprit is https://github.com/hackademix/noscript/ ... e641b7ca49

Creating a NoScript 11.2.5rc3 xpi with that commit reverted, and from a clean nscl revision d9e20fdcb805f226d795c0068e68563c8dfeea39, this problem does not exist.

Re: 11.2.5rc3 messes up ghacks layout

Posted: Sun May 02, 2021 7:48 pm
by Giorgio Maone
Should be fixed in latest development build, thanks.
v 11.2.5rc4
============================================================
x Fixed regression in NOSCRIPT emulation (thanks barbaz for
reporting)

Re: 11.2.5rc3 messes up ghacks layout

Posted: Sun May 02, 2021 8:22 pm
by barbaz
Confirmed fixed in 11.2.5rc4, thanks! Image

Re: [Fixed] 11.2.5rc3 messes up ghacks layout

Posted: Mon May 03, 2021 11:04 am
by skriptimaahinen
Unless I'm completely mistaken, running querySelector in MutationObserver callback is likely not going to do what you hope it does as the nodes are quite not yet added to the DOM. You need to check the records.

Re: [Fixed] 11.2.5rc3 messes up ghacks layout

Posted: Mon May 03, 2021 2:22 pm
by Giorgio Maone
skriptimaahinen wrote: Mon May 03, 2021 11:04 am Unless I'm completely mistaken
Yes, you are, once in a while :)
MutationObserver callbacks are called after the DOM is modified (but before most side effects of that modification, like repaints or script parsing and execution, happen).
In facts if you don't like the change you cannot prevent it, but you can revert it. And that's also the reason why you can request for (attribute|characterData)OldValue is supported.

Re: [Fixed] 11.2.5rc3 messes up ghacks layout

Posted: Tue May 04, 2021 6:40 am
by skriptimaahinen
No idea why I thought that was the case. Should always check before I open my mouth. :oops: