Like the title says. https://www.ghacks.net/latest-posts/ is supposed to load in a multi-column format. With 11.2.5rc3 it instead loads in a single, full-width column, and the links are missing almost all styling.
Downgrading NoScript to 11.2.5rc2 and the site has correct styling.
[Fixed] 11.2.5rc3 messes up ghacks layout
[Fixed] 11.2.5rc3 messes up ghacks layout
*Always* check the changelogs BEFORE updating that important software!
-
Re: 11.2.5rc3 messes up ghacks layout
(Confirmed. FF 78.10.0, 11.2.5rc3.)
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 Pinball NoScript FlashGot AdblockPlus
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 SeaMonkey/2.53.7.1
Re: 11.2.5rc3 messes up ghacks layout
I think the culprit is https://github.com/hackademix/noscript/ ... e641b7ca49
Creating a NoScript 11.2.5rc3 xpi with that commit reverted, and from a clean nscl revision d9e20fdcb805f226d795c0068e68563c8dfeea39, this problem does not exist.
Creating a NoScript 11.2.5rc3 xpi with that commit reverted, and from a clean nscl revision d9e20fdcb805f226d795c0068e68563c8dfeea39, this problem does not exist.
*Always* check the changelogs BEFORE updating that important software!
-
- Giorgio Maone
- Site Admin
- Posts: 9454
- Joined: Wed Mar 18, 2009 11:22 pm
- Location: Palermo - Italy
- Contact:
Re: 11.2.5rc3 messes up ghacks layout
Should be fixed in latest development build, thanks.
v 11.2.5rc4
============================================================
x Fixed regression in NOSCRIPT emulation (thanks barbaz for
reporting)
v 11.2.5rc4
============================================================
x Fixed regression in NOSCRIPT emulation (thanks barbaz for
reporting)
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:89.0) Gecko/20100101 Firefox/89.0
Re: 11.2.5rc3 messes up ghacks layout
Confirmed fixed in 11.2.5rc4, thanks!
*Always* check the changelogs BEFORE updating that important software!
-
-
- Master Bug Buster
- Posts: 244
- Joined: Wed Jan 10, 2018 7:37 am
Re: [Fixed] 11.2.5rc3 messes up ghacks layout
Unless I'm completely mistaken, running querySelector in MutationObserver callback is likely not going to do what you hope it does as the nodes are quite not yet added to the DOM. You need to check the records.
Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Firefox/78.0
- Giorgio Maone
- Site Admin
- Posts: 9454
- Joined: Wed Mar 18, 2009 11:22 pm
- Location: Palermo - Italy
- Contact:
Re: [Fixed] 11.2.5rc3 messes up ghacks layout
Yes, you are, once in a while
MutationObserver callbacks are called after the DOM is modified (but before most side effects of that modification, like repaints or script parsing and execution, happen).
In facts if you don't like the change you cannot prevent it, but you can revert it. And that's also the reason why you can request for (attribute|characterData)OldValue is supported.
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:89.0) Gecko/20100101 Firefox/89.0
-
- Master Bug Buster
- Posts: 244
- Joined: Wed Jan 10, 2018 7:37 am
Re: [Fixed] 11.2.5rc3 messes up ghacks layout
No idea why I thought that was the case. Should always check before I open my mouth.
Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Firefox/78.0