yellow mousover

Bug reports and enhancement requests
Tobey
Posts: 1
Joined: Mon May 18, 2020 4:26 pm

yellow mousover

Post by Tobey » Mon May 18, 2020 4:32 pm

Hi,
I reinstalled my computer today and installed the latest version of noscript-11.0.26. Since then, the buttons on mouseover have been yellow and the first button is always shown in yellow.
The problem did not exist when installing version 11.0.25. I was able to reproduce it on a VM, but the Appdata folder in the user context must be deleted.
When updating from an older version of noscript, the problem does not seem to exist.
Is this behavior a bug?

Best regards
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0

User avatar
therube
Ambassador
Posts: 7584
Joined: Thu Mar 19, 2009 4:17 pm
Location: Maryland USA

Re: yellow mousover

Post by therube » Mon May 18, 2020 6:15 pm

If you disable NoScript, does the problem persist?
If you restart FF in Safe Mode, does the problem persist?

Does this only happen on FF 68 or does it happen on FF Release also?
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 Pinball NoScript FlashGot AdblockPlus
Mozilla/5.0 (Windows NT 5.1; rv:52.0) Gecko/20100101 SeaMonkey/2.49.5

User avatar
Giorgio Maone
Site Admin
Posts: 8815
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: yellow mousover

Post by Giorgio Maone » Mon May 18, 2020 6:28 pm

Confirmed, it's a cosmetic regression from massive changes in the UI stylesheets for better usability on mobile phones in portrait mode.
Hope it's not too terrible to bear until next stable version.
Where some more changes however may still require an "active widget" indicator because I'd like to finally address long-standing accessibility issues, i.e. keyboard navigation.
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:77.0) Gecko/20100101 Firefox/77.0

barbaz
Senior Member
Posts: 9466
Joined: Sat Aug 03, 2013 5:45 pm

Re: yellow mousover

Post by barbaz » Mon May 18, 2020 6:29 pm

I see the same on 76.0.1, with NoScript 11.0.26rc2.

Image

This is an accessibility bug. That yellow color against the white/grey background of non-mouse-hovered permission entry is hard to see and hurts my eyes.

Giorgio, can you please use a different color, or only use the yellow color on mouse hover where it's against a blue-purple background?

EDIT Oops, collided posting with Giorgio
*Always* check the changelogs BEFORE updating that important software!
-

barbaz
Senior Member
Posts: 9466
Joined: Sat Aug 03, 2013 5:45 pm

Re: yellow mousover

Post by barbaz » Mon May 18, 2020 7:08 pm

Giorgio Maone wrote:
Mon May 18, 2020 6:28 pm
Where some more changes however may still require an "active widget" indicator because I'd like to finally address long-standing accessibility issues, i.e. keyboard navigation.
I played around with the color a bit. Pink (#f9e) seems to work reasonably well.

Also adding a similar-colored box-shadow (I tried #f0f) helps make it more distinctive. But pink/magenta box-shadow doesn't look great on the yellow permissions customisations (e.g. open Custom), but that's just a cosmetic problem.
*Always* check the changelogs BEFORE updating that important software!
-

User avatar
therube
Ambassador
Posts: 7584
Joined: Thu Mar 19, 2009 4:17 pm
Location: Maryland USA

Re: yellow mousover

Post by therube » Mon May 18, 2020 10:33 pm

That yellow color against the white/grey background of non-mouse-hovered permission entry is hard to see and hurts my eyes.
Screenshot?
I see nothing (guess I could put a shot up of Sgt. Schultz).

Wonder if it has to do with (Windows) Aero (or whatever it's called - which I don't use)?
(Where non-Aero is greatly affected, I am, by https://bugzilla.mozilla.org/show_bug.cgi?id=1637497.)
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 Pinball NoScript FlashGot AdblockPlus
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 SeaMonkey/2.53.3 Lightning/5.8.3

barbaz
Senior Member
Posts: 9466
Joined: Sat Aug 03, 2013 5:45 pm

Re: yellow mousover

Post by barbaz » Mon May 18, 2020 10:59 pm

therube wrote:
Mon May 18, 2020 10:33 pm
That yellow color against the white/grey background of non-mouse-hovered permission entry is hard to see and hurts my eyes.
Screenshot?
Image
therube wrote:
Mon May 18, 2020 10:33 pm
Wonder if it has to do with (Windows) Aero (or whatever it's called - which I don't use)?
(Where non-Aero is greatly affected, I am, by https://bugzilla.mozilla.org/show_bug.cgi?id=1637497.)
I'm on Linux.
*Always* check the changelogs BEFORE updating that important software!
-

Redbeard
Posts: 1
Joined: Tue May 19, 2020 12:38 am

Re: yellow mousover

Post by Redbeard » Tue May 19, 2020 12:42 am

I'm also running on Linux and am seeing the yellow-highlighted buttons but I don't have to hover over them with my mouse to see the highlighting. My only complaint is that I don't know what the highlighting indicates.
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

barbaz
Senior Member
Posts: 9466
Joined: Sat Aug 03, 2013 5:45 pm

Re: yellow mousover

Post by barbaz » Tue May 19, 2020 1:11 am

@Redbeard
Giorgio Maone wrote:
Mon May 18, 2020 6:28 pm
an "active widget" indicator
*Always* check the changelogs BEFORE updating that important software!
-

User avatar
therube
Ambassador
Posts: 7584
Joined: Thu Mar 19, 2009 4:17 pm
Location: Maryland USA

Re: yellow mousover

Post by therube » Tue May 19, 2020 3:05 am

Image
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 Pinball NoScript FlashGot AdblockPlus
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 SeaMonkey/2.53.3 Lightning/5.8.3

bo elam
Senior Member
Posts: 208
Joined: Sat Oct 14, 2017 2:25 am

Re: yellow mousover

Post by bo elam » Sat May 23, 2020 11:56 pm

I just updated to Firefox 76.0.1 and NoScript 11.0.26. And found this yellow thing. It is very distracting and annoying. Hopefully, Giorgio will be able to fix it in the next stable release. I am tempted on going back to 11.0.25 but I ll stay put (only because it is NoScript). :)

Bo
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0

barbaz
Senior Member
Posts: 9466
Joined: Sat Aug 03, 2013 5:45 pm

Re: yellow mousover

Post by barbaz » Tue May 26, 2020 1:55 am

barbaz wrote:
Mon May 18, 2020 6:29 pm
This is an accessibility bug. That yellow color against the white/grey background of non-mouse-hovered permission entry is hard to see and hurts my eyes.
Since there is still no new NoScript version with a fix for this, I ended up taking to userContent.css -

Code: Select all

@-moz-document url-prefix("moz-extension://<your unique ID for NoScript>/") {

html:not(.mobile) tr.site:not(:hover) input.preset:active:not(:hover),
html:not(.mobile) tr.site:not(:hover) input.preset:focus:not(:hover) {
  background-color: #7cf !important;
}

html:not(.mobile) input.preset:checked {
  transition: background-color 0.16s ease-in 0s;
}

}
This intentionally doesn't touch the yellow color on mouse hover, it's only an attempt to work around the accessibility bug.
*Always* check the changelogs BEFORE updating that important software!
-

barbaz
Senior Member
Posts: 9466
Joined: Sat Aug 03, 2013 5:45 pm

Re: yellow mousover

Post by barbaz » Thu May 28, 2020 7:07 pm

Thanks Giorgio for fixing this in 11.0.27rc1, much better Image
*Always* check the changelogs BEFORE updating that important software!
-

barbaz
Senior Member
Posts: 9466
Joined: Sat Aug 03, 2013 5:45 pm

Re: yellow mousover

Post by barbaz » Sun May 31, 2020 3:12 am

barbaz wrote:
Mon May 18, 2020 6:29 pm
This is an accessibility bug. That yellow color against the white/grey background of non-mouse-hovered permission entry is hard to see and hurts my eyes.

Giorgio, can you please use a different color,
Regressed in 11.0.27rc2 :( Unfortunately the new yellow color is too similar to the problematic color that was in 11.0.26rc2, it is still hard to look at.

I'll play around with the colors a bit and try to come up with a specific suggestion.
*Always* check the changelogs BEFORE updating that important software!
-

User avatar
therube
Ambassador
Posts: 7584
Joined: Thu Mar 19, 2009 4:17 pm
Location: Maryland USA

Re: yellow mousover

Post by therube » Sun May 31, 2020 10:31 am

And now I am seeing 'ol yeller (where before I did not).

Image

Main site domain, has that odd yellow highlight.
Mouseover gives full row yellow.


(I actually don't mind either ;-).)


Win7, non-Aero theme
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 Pinball NoScript FlashGot AdblockPlus
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 SeaMonkey/2.53.3 Lightning/5.8.3

Post Reply