NoScript Options, Custom puts domain in Custom mode

Bug reports and enhancement requests
Post Reply
User avatar
therube
Ambassador
Posts: 7929
Joined: Thu Mar 19, 2009 4:17 pm
Location: Maryland USA

NoScript Options, Custom puts domain in Custom mode

Post by therube »

NoScript | Options (I guess that's what you call it?), Custom, puts domain in Custom mode regardless of whether you've effected a change or not.

Should it?

And worse yet, those permissions persist (as in a Revoke does not have an affect on them).
So even an inadvertent click of Custom (automatically) changes a domain to Allowed (essentially).


And you're going to say there is a Temporarily Allow Custom.
Well, I didn't even see that.

No, the behavior is wrong, dangerous.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 Pinball NoScript FlashGot AdblockPlus
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.5
User avatar
Giorgio Maone
Site Admin
Posts: 9454
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: NoScript Options, Custom puts domain in Custom mode

Post by Giorgio Maone »

Do you mean you expect a site to be left with the CUSTOM preset assigned only and only if you click some checkbox, too?
I can see the rationale, but
  1. the other presets take effect immediately
  2. whenever you click CUSTOM, the preset currently in effect gets copied, so you're never giving more permissions than the current until you interact with the capability checkboxs. For instance, if you click "CUSTOM" on a currently UNTRUSTED entry, you get no permissions at all.
However, there's a little caveat to rule #2, which is what you're ranting about last: the "temporary" flag doesn't get copied, hence if you click CUSTOM on a site which is currently TEMP. TRUSTED, you automatically turn it into permanently TRUSTED. Which, at the time I implemented it, seemed like a feature to me: once you choose to customize permissions for a site, you probably want the customized settings to stick.

So, you're probably right: the best course of action would be either copying the temporary flag as well, or making CUSTOM stick only if you actually changed something on top of the copied capabilities.
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
musonius
Master Bug Buster
Posts: 203
Joined: Sun Jul 08, 2018 5:38 pm

Re: NoScript Options, Custom puts domain in Custom mode

Post by musonius »

Giorgio Maone wrote:So, you're probably right: the best course of action would be either copying the temporary flag as well, or making CUSTOM stick only if you actually changed something on top of the copied capabilities.
Both options do not necessarily exclude each other. For example, it makes sense to allow temporary less than TRUSTED, but more than DEFAULT, and one could first click Temp. TRUSTED and then move to CUSTOM to disallow something and still want to have a temporary CUSTOM. The question is, which behavior is most intuitive?
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
skriptimaahinen
Master Bug Buster
Posts: 244
Joined: Wed Jan 10, 2018 7:37 am

Re: NoScript Options, Custom puts domain in Custom mode

Post by skriptimaahinen »

Personally I would prefer the CUSTOM rule to be initiated as TEMPORARY and stay so until manually changed to permanent.

However this might not suit all, so maybe a option for it?
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0
barbaz
Senior Member
Posts: 10847
Joined: Sat Aug 03, 2013 5:45 pm

Re: NoScript Options, Custom puts domain in Custom mode

Post by barbaz »

skriptimaahinen wrote:Personally I would prefer the CUSTOM rule to be initiated as TEMPORARY and stay so until manually changed to permanent.

However this might not suit all, so maybe a option for it?
Such option was already requested in https://forums.informaction.com/viewtop ... 10&t=25104
*Always* check the changelogs BEFORE updating that important software!
-
Post Reply