[Fixed] 10.1.7.2rc1 does not display <noscript> tags

Bug reports and enhancement requests
Post Reply
barbaz
Senior Member
Posts: 9280
Joined: Sat Aug 03, 2013 5:45 pm

[Fixed] 10.1.7.2rc1 does not display <noscript> tags

Post by barbaz » Fri Mar 16, 2018 2:36 pm

NoScript 10.1.7.2rc1
Firefox 59
new profile

Visit https://javatester.org/javascript.html, make sure scripts are blocked for that domain

The "Test Results" box should show a red box saying "JavaScript IS NOT WORKING in your web browser". But it's empty.

10.1.7rc4 works better, but still not fully (the info is displayed but missing some styling).
*Always* check the changelogs BEFORE updating that important software!
-

fatboy
Senior Member
Posts: 53
Joined: Fri Jul 25, 2014 6:56 am
Contact:

Re: 10.1.7.2rc1 does not display <noscript> tags

Post by fatboy » Fri Mar 16, 2018 4:32 pm

Fx 57
NS 10.1.7rc3-10.1.7.2 — does not display <noscript> and meta redirection does not work.
(for example https://vk.com , https://encrypted.google.com/ -> "test")
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:41.0) Gecko/20100101 SM/2.38 NS/2.9.0.12

User avatar
Giorgio Maone
Site Admin
Posts: 8742
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: 10.1.7.2rc1 does not display <noscript> tags

Post by Giorgio Maone » Fri Mar 16, 2018 11:48 pm

Should be fixed in latest development build, please confirm.
v 10.1.7.3rc1
=============================================================
x Fixed infinite script count report loops on some sites
(thanks AuntyJack, @ALoss2 and others for reporting)
x Fixed localhost not being recognized as a domain (thanks
skriptimaahinen for patch)
x Fixed regression causing NOSCRIPT element and META refreshes
not to be emulated anymore on script-disabled pages (thanks
barbaz and fatboy for reporting)
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0

barbaz
Senior Member
Posts: 9280
Joined: Sat Aug 03, 2013 5:45 pm

Re: 10.1.7.2rc1 does not display <noscript> tags

Post by barbaz » Sat Mar 17, 2018 1:21 am

Thanks Giorgio, now it's back to the 10.1.7rc4 behavior. But that's still not fully fixed.

The problem stems from NoScript replacing <noscript> tags with <div>'s. The effect can be seen with this test page -

Code: Select all

<!doctype html>
<div>This is a <noscript>JS-disabled</noscript> test!</div>
NoScript Classic with scripts disabled shows
This is a JS-disabled test!
NoScript 10.1.7.3rc1 with scripts disabled shows -
This is a
JS-disabled
test!
I would suggest to fix it by instead replacing <noscript> tags with <span> instead of <div>.
*Always* check the changelogs BEFORE updating that important software!
-

barbaz
Senior Member
Posts: 9280
Joined: Sat Aug 03, 2013 5:45 pm

Re: 10.1.7.2rc1 does not display <noscript> tags

Post by barbaz » Mon Jul 09, 2018 2:18 am

barbaz wrote:Thanks Giorgio, now it's back to the 10.1.7rc4 behavior. But that's still not fully fixed.

The problem stems from NoScript replacing <noscript> tags with <div>'s. The effect can be seen with this test page -

Code: Select all

<!doctype html>
<div>This is a <noscript>JS-disabled</noscript> test!</div>
NoScript Classic with scripts disabled shows
This is a JS-disabled test!
NoScript 10.1.7.3rc1 with scripts disabled shows -
This is a
JS-disabled
test!
This was discussed in https://forums.informaction.com/viewtop ... =7&t=25014 and fixed in 10.1.8.3rc8 Image
*Always* check the changelogs BEFORE updating that important software!
-

Post Reply