[FIXED] Bug: Clicking label instead of checkbox broken

Bug reports and enhancement requests
Post Reply
dhouwn
Bug Buster
Posts: 968
Joined: Thu Mar 19, 2009 12:51 pm

[FIXED] Bug: Clicking label instead of checkbox broken

Post by dhouwn » Sat Dec 02, 2017 7:57 am

Changing what is allowed for a certain scope does not work when clicking on the label instead of the checkbox itself.

Noscript 10.1.5.1

(BTW, is it true that we will see Noscript at a public source code and bug tracker like Github/Bitbucket/Gitlab in the future?)
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0

barbaz
Senior Member
Posts: 9262
Joined: Sat Aug 03, 2013 5:45 pm

Re: Bug: Clicking label instead of checkbox broken

Post by barbaz » Sat Dec 02, 2017 4:20 pm

dhouwn wrote:Changing what is allowed for a certain scope does not work when clicking on the label instead of the checkbox itself.

Noscript 10.1.5.1
Same here. Clicking the label looks like it's changing the setting, but it actually just causes the list of what is allowed for the scope to close.
*Always* check the changelogs BEFORE updating that important software!
-

olf
Posts: 10
Joined: Sun Dec 03, 2017 3:10 pm

Re: Bug: Clicking label instead of checkbox broken

Post by olf » Sun Dec 03, 2017 6:11 pm

dhouwn wrote:Changing what is allowed for a certain scope does not work when clicking on the label instead of the checkbox itself.
Noscript 10.1.5.1
I have reproduced this behavior with NoScript 10.1.2 under Firefox for Android in the site specific settings page.
This is extremely annoying on a Smartphone, as one has to explicitly hit the checkbox (although the site specific settings page can be zoomed, which alleviates this usability issue a bit).

Although with recent releases of NoScript (tested 10.1.5.3 and 10.1.5.4rc1) tapping on the descriptive text of a checkbox works in the global options (site specific settings ceased to work at all since NoScript 10.1.3c1 under Firefox for Android, see https://forums.informaction.com/viewtop ... 10&t=24042), an activated setting does not persist: When returning to the global settings later, it is unset again!
dhouwn wrote:(BTW, is it true that we will see Noscript at a public source code and bug tracker like Github/Bitbucket/Gitlab in the future?)
That would be just great! A real issue tracker etc.
Mozilla/5.0 (Android 4.1.2; Mobile; rv:56.0) Gecko/56.0 Firefox/56.0

olf
Posts: 10
Joined: Sun Dec 03, 2017 3:10 pm

Re: Bug: Clicking label instead of checkbox broken

Post by olf » Sat Dec 16, 2017 7:27 am

Retested with NoScript 10.1.5.8rc3 under Firefox for Android:

- Clicking on an option label in the general options still works.
- Now the activated options in the general options do persist!
- But clicking on a label in the site specific settings still does not work!
Mozilla/5.0 (Android 4.1.2; Mobile; rv:57.0) Gecko/57.0 Firefox/57.0

olf
Posts: 10
Joined: Sun Dec 03, 2017 3:10 pm

Re: Bug: Clicking label instead of checkbox broken

Post by olf » Mon Jan 15, 2018 12:19 am

Retested with NoScript 10.1.6.3 under Firefox for Android:

Clicking on a label in an open scope ("bubble") in any site specific settings still does not work.

- Expected behaviour: The corresponding filter property is activated (i.e. its checkbox becomes ticked), after clicking on its label. The scope stays open.
- Actual behaviour: The open scope is closed, but the filter property not activated (i.e. its checkbox not ticked), after clicking on its label.
Mozilla/5.0 (Android 4.1.2; Mobile; rv:57.0) Gecko/57.0 Firefox/57.0

User avatar
Giorgio Maone
Site Admin
Posts: 8732
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: Bug: Clicking label instead of checkbox broken

Post by Giorgio Maone » Mon Jan 15, 2018 11:38 am

Please check latest development build:
v 10.1.6.4rc2
=============================================================
x [UI] Fixed clicking on capability's label doesn't toggle
the related checkbox (thanks dhouwn and olf for reporting)
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

barbaz
Senior Member
Posts: 9262
Joined: Sat Aug 03, 2013 5:45 pm

Re: Bug: Clicking label instead of checkbox broken

Post by barbaz » Mon Jan 15, 2018 3:26 pm

Fixed here, thank you Giorgio! Image
*Always* check the changelogs BEFORE updating that important software!
-

olf
Posts: 10
Joined: Sun Dec 03, 2017 3:10 pm

Re: [FIXED] Bug: Clicking label instead of checkbox broken

Post by olf » Mon Jan 15, 2018 8:12 pm

+1
Ack: NoScript 10.1.6.4rc2 does that nicely.
Thanks!
Mozilla/5.0 (Android 4.1.2; Mobile; rv:57.0) Gecko/57.0 Firefox/57.0

Post Reply