Page 1 of 1

[FIXED] Can't edit ABE rules

Posted: Sat Nov 18, 2017 3:26 pm
by Rollo
Hi,
starting with NoScript version 5.1.6rc1 I can't no more edit ABE rules.
Relevant (?) console error:
Image

FireFox 52.5 ESR and SeaMonkey 2.49.1 - Debian Stable x86_64 in a new, clean profile.
No problem with NoScript version 5.1.5

Re: Can't edit ABE rules

Posted: Sat Nov 18, 2017 3:40 pm
by barbaz
I see the same problem in NoScript 5.1.7rc1.

Re: Can't edit ABE rules

Posted: Tue Dec 05, 2017 5:34 am
by barbaz
Still broken in 5.1.8.1.

The relevant code in 5.1.8.1 -

Code: Select all

  saveRuleset: function(name, source) {
    COMPAT.setStringPref(this.prefs, "rulesets." + name, str);
  },
Looks like this bug might just be a typo?

Re: Can't edit ABE rules

Posted: Tue Dec 05, 2017 8:01 am
by Rollo
barbaz wrote:Still broken in 5.1.8.1.
Can confirm, still broken for me too in 5.1.8.1.
Also broken on current TOR Browser, I just checked out of curiosity.

Re: Can't edit ABE rules

Posted: Fri Dec 08, 2017 4:33 am
by barbaz
barbaz wrote:Still broken in 5.1.8.1.

The relevant code in 5.1.8.1 -

Code: Select all

  saveRuleset: function(name, source) {
    COMPAT.setStringPref(this.prefs, "rulesets." + name, str);
  },
Looks like this bug might just be a typo?
And indeed, this patch looks to fix the problem -

Code: Select all

diff --git a/chrome/content/noscript/ABE.js b/chrome/content/noscript/ABE.js
--- a/chrome/content/noscript/ABE.js
+++ b/chrome/content/noscript/ABE.js
@@ -1257,7 +1257,7 @@
   },
 
   saveRuleset: function(name, source) {
-    COMPAT.setStringPref(this.prefs, "rulesets." + name, str);
+    COMPAT.setStringPref(this.prefs, "rulesets." + name, source);
   },
 
   persist: function() {

Re: Can't edit ABE rules

Posted: Fri Dec 08, 2017 8:58 pm
by Giorgio Maone
Merging, thanks!

Re: Can't edit ABE rules

Posted: Fri Dec 08, 2017 11:48 pm
by barbaz
Fixed in 5.1.8.2rc6 Image

Re: Can't edit ABE rules

Posted: Sat Dec 09, 2017 7:19 pm
by gracious1
barbaz wrote:Fixed in 5.1.8.2rc6 Image
Hooray!
And how do you get that dancing banana smiley?