5.1.4 Bookmarklets Broken if site is NOT Allowed

Bug reports and enhancement requests
Post Reply
User avatar
therube
Ambassador
Posts: 7929
Joined: Thu Mar 19, 2009 4:17 pm
Location: Maryland USA

5.1.4 Bookmarklets Broken if site is NOT Allowed

Post by therube »

5.1.4 Bookmarklets Broken if site is NOT Allowed

I think that is what I'm seeing?

Though I don't think I saw that when I first put in 5.1.4, restartless.
Though I am now after browser restart.

FF 56
No e10s


(SeaMonkey looks to be working as expected.)


Something else must be going on.
Working in a new Profile with only NoScript installed.


So far, unable to get it to break in a new Profile.

So far, unable to get existing Profile bookmarklets to work again :( .
Browser restart, enable/disable all extension sequence...


In existing, non-working Profile, clicking a bookmarklet spams Error Console:

Code: Select all

ScriptSurrogate.createSandboxForWindow is not a function  JSURL.js:65

Allow the site, bookmarklet works & no Error Console spam.
Disable the site, bookmarklet does not work, & Error Console is spammed.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 Pinball NoScript FlashGot AdblockPlus
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.1 Lightning/5.4
User avatar
Giorgio Maone
Site Admin
Posts: 9454
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: 5.1.4 Bookmarklets Broken if site is NOT Allowed

Post by Giorgio Maone »

It seems we're repeatedly hit by caching / version overlapping issues with the extensions manager + restartless (it seems you've got a part of NoScript 5.1.4 calling an "older" ScriptSurrogate object). Worth investigating further...
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
User avatar
therube
Ambassador
Posts: 7929
Joined: Thu Mar 19, 2009 4:17 pm
Location: Maryland USA

Re: 5.1.4 Bookmarklets Broken if site is NOT Allowed

Post by therube »

(Dropped back to 5.1.3, restartless, & bookmarklets started working immediately.
Put in 5.1.4, restartless, & the NoScript icon showed & seemingly was ? Allow Globally.
Disallow Globally, & manually refresh the page & the icon still showed Allow Globally.
Disallowed again, & now the icon shows correctly.
[It seemed that's how the procedure went. No clue whats going on, but then I haven't know that for a good while now.]
Anyhow... restartless 5.1.4, bookmarklets are working...
And on a browser restart, bookmarklets are again broken.)
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 Pinball NoScript FlashGot AdblockPlus
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.1 Lightning/5.4
User avatar
therube
Ambassador
Posts: 7929
Joined: Thu Mar 19, 2009 4:17 pm
Location: Maryland USA

Re: 5.1.4 Bookmarklets Broken if site is NOT Allowed

Post by therube »

After being up & down the NoScript trial, finally resolving myself back to 5.0.10...


To note, Unsigned Extensions Hack - Bypass Firefox's Add-on Signing may have had some bearing on this (or not).


I did have the hack - nothing in my Profile directory, but in the FF instalDir.
Remove the hack.
Then thought... what if...

And with that, I did a "dirty" install of 5.1.4...

FF is closed
Copy 5.1.4.xpi overtop existing /extensions/...3232}.xpi

Start FF

Initially no NoScript icon, crap
And it doesn't seem to be working, double crap
But the extension is "installed" (in Addons Manager) [or so it says]
So I disable it, then enable it

With that, NoScript turns up & is actually working


Test bookmarklets, working.

Quit FF

Put the signing bypass hack back in

Start FF


Bookmarklets still working.


Even if (?) the signing bypass "hack" played a part in this, it did not in other Profiles (opened from the same FF "install")...


So, where are we, now?

Now, bookmarklets are working in my (old, existing FF Profile), with NoScript 5.1.4.
(Dare I blink.)


Ah well, just keep in mind, things "in" FF, but outside of your Profile can have an affect on what you get.
Was there an affect here? As it is, can't say.
(Feel free to correct me on my a's vs e's.)
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 Pinball NoScript FlashGot AdblockPlus
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.1 Lightning/5.4
Post Reply