[FIXED]ABE incorrectly thinks most requests are type "other"

[Giorgio Maone]

surely discriminating MEDIA and FONT is more useful. Sigh.

In latest development build 5.0.8rc6, thanks.

[barbaz]

LGTM, many thanks for getting this sorted!

[barbaz]

PLD pointed out to me that INC(OTHER) now matches TYPE_XBL and TYPE_PING. I did some testing, this wasn't the case before.

Given that the browser blocks PING by default, and allowing XBL requires an addon, I would doubt this change matters. But for those who need the distinction, you can do something like

Code: Select all

Accept INC(PING, XBL)
Deny INC(OTHER)

[PLD]

Something else. With 2.9.5.3, an attempt to do this:

Code: Select all

Site ALL
Deny INC(NEWTYPE)

will be rejected because NEWTYPE isn't recognized. However, it looks like 5.0.8.1 will accept that rule.

Wondering out loud: What would happen if TYPE_NEWTYPE was added to nsIContentPolicy types? How would the existing code react to that scenario, if NS 5.0.8.1 were installed in such a browser? Would TYPE_NEWTYPE be added to the types matched by OTHER? Would the request processing and various accept/deny INC(NEWTYPE) rules work

Code: Select all

Site ALL
Accept INC(NEWTYPE)
Deny INC(OTHER)

when NoScript doesn't actually know what TYPE_NEWTYPE is?