In latest development build 5.0.8rc6, thanks.Giorgio Maone wrote:surely discriminating MEDIA and FONT is more useful. Sigh.
[FIXED]ABE incorrectly thinks most requests are type "other"
- Giorgio Maone
- Site Admin
- Posts: 9454
- Joined: Wed Mar 18, 2009 11:22 pm
- Location: Palermo - Italy
- Contact:
Re: [e10s] ABE incorrectly thinks most requests are type "ot
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0
Re: [e10s] ABE incorrectly thinks most requests are type "ot
LGTM, many thanks for getting this sorted!
*Always* check the changelogs BEFORE updating that important software!
-
Re: [FIXED]ABE incorrectly thinks most requests are type "ot
PLD pointed out to me that INC(OTHER) now matches TYPE_XBL and TYPE_PING. I did some testing, this wasn't the case before.
Given that the browser blocks PING by default, and allowing XBL requires an addon, I would doubt this change matters. But for those who need the distinction, you can do something like
Given that the browser blocks PING by default, and allowing XBL requires an addon, I would doubt this change matters. But for those who need the distinction, you can do something like
Code: Select all
Accept INC(PING, XBL)
Deny INC(OTHER)
*Always* check the changelogs BEFORE updating that important software!
-
Re: [FIXED]ABE incorrectly thinks most requests are type "ot
Something else. With 2.9.5.3, an attempt to do this:
will be rejected because NEWTYPE isn't recognized. However, it looks like 5.0.8.1 will accept that rule.
Wondering out loud: What would happen if TYPE_NEWTYPE was added to nsIContentPolicy types? How would the existing code react to that scenario, if NS 5.0.8.1 were installed in such a browser? Would TYPE_NEWTYPE be added to the types matched by OTHER? Would the request processing and various accept/deny INC(NEWTYPE) rules work
when NoScript doesn't actually know what TYPE_NEWTYPE is?
Code: Select all
Site ALL
Deny INC(NEWTYPE)
Wondering out loud: What would happen if TYPE_NEWTYPE was added to nsIContentPolicy types? How would the existing code react to that scenario, if NS 5.0.8.1 were installed in such a browser? Would TYPE_NEWTYPE be added to the types matched by OTHER? Would the request processing and various accept/deny INC(NEWTYPE) rules work
Code: Select all
Site ALL
Accept INC(NEWTYPE)
Deny INC(OTHER)
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0