Page 2 of 3

some sites don't reload after changing permission

Posted: Sun Dec 11, 2016 7:27 pm
by ThomasW
hello,

as the title says. one of the sites i came across this is

https://html5test.com

- allow html5test.com
- allow whichbrowser.net

the site does not reload, i ave to do it manually. i've seen this on other sites, too.
it worked with older noscript versions.

firefox v52 on windows, noscript 2.9.5.2

thanks a lot. :)

Re: (2.9.5rc35) Automatic reload broken?

Posted: Sun Dec 11, 2016 8:03 pm
by barbaz
Threads merged.

Re: (2.9.5.3rc6) Automatic reload broken?

Posted: Sun Jan 22, 2017 10:06 pm
by barbaz
Threads merged. nvm, split again to viewtopic.php?f=10&t=22539

Re: (2.9.5.3rc6) Automatic reload broken?

Posted: Wed Feb 01, 2017 2:11 am
by barbaz
As of yesterday, Youtube can no longer be used for STR, as they've stopped serving scripts from ytimg.com. I'll have to find another affected site.

Re: (2.9.5.3rc6) Automatic reload broken?

Posted: Wed Feb 01, 2017 2:32 pm
by ThomasW
noscript.autoReload.allTabs = true

hm... that doesn't seem to work on

https://html5test.com/

first i have to allow html5test.com, this does reload

then i also have to allow whichbrowser.net, this does not reload.

Re: (5.0rc1) Automatic reload broken?

Posted: Wed Feb 01, 2017 5:39 pm
by barbaz
Thanks ThomasW! I've replaced the Youtube link with html5test.com in the STR.
ThomasW wrote:noscript.autoReload.allTabs = true

hm... that doesn't seem to work on

https://html5test.com/

first i have to allow html5test.com, this does reload

then i also have to allow whichbrowser.net, this does not reload.
Same results here.

Re: (5.0rc1) Automatic reload broken?

Posted: Wed Feb 01, 2017 6:14 pm
by yes_noscript
As workaround i now allow all JavaScripts in NoScript and use the script allow in uMatrix.
Before that i allow javascripts both in NoScript and uMatrix but its a lot more work.

So with this bug in NoScript i need manualy reload and i need to allow elements in uMatrix too...so i prefer do it in uMatrix

Re: (5.0rc1) Automatic reload broken?

Posted: Thu Feb 02, 2017 5:50 am
by barbaz
@cartel: Sorry about the incorrect thread merging. Split your bug report to viewtopic.php?f=10&t=22539.

Re: (5.0rc1) Automatic reload broken?

Posted: Sun May 28, 2017 1:29 pm
by barbaz

Re: (5.0.5rc12) Automatic reload broken?

Posted: Fri Aug 18, 2017 6:49 pm
by ThomasW
seems this won't get fixed, sadly.

Re: (5.0.5rc12) Automatic reload broken?

Posted: Fri Aug 18, 2017 7:01 pm
by barbaz
I confirm this is still a problem in 5.0.9rc1.
ThomasW wrote:seems this won't get fixed, sadly.
Seems Giorgio is quite swamped designing WebExtensions APIs and rewriting NoScript for WebExtensions.

It will get fixed, but don't be surprised if it doesn't happen until after NoScript 10 is out.

Re: (5.0.9rc1) Automatic reload broken?

Posted: Mon Jul 09, 2018 10:41 pm
by barbaz
bump

Still an issue in 5.1.8.7rc2.

Re: (classic) Automatic reload broken?

Posted: Tue Aug 28, 2018 3:49 pm
by barbaz
Bump.

This bug still persists in NoScript 5.1.8.7rc3. Giorgio, do you need any more information from me to fix this?

Re: (classic) Automatic reload broken?

Posted: Tue Aug 28, 2018 4:54 pm
by therube
(And I have always though this behavior was expected, as I see this fairly regularly & have just become accustomed to it. When I allow a particular domain & I get no refresh, & I expect there should be a refresh, I just do, manually.)

Re: (classic) Automatic reload broken?

Posted: Wed Aug 29, 2018 2:21 am
by barbaz
I did some more investigation.

There maybe two bugs here. One of them occurs when "Reload the current tab only" is checked, the other when "Reload the current tab only" is un-checked.

The former seems caused by MainChild.js isCurrentFrame comparing different window IDs when I would think they're supposed to be the same. It causes NoScript to erroneously conclude that the permission change isn't relevant for the current tab, so NoScript bails early and doesn't reload anything.

The latter bug is confusing me. I'm getting weird results that don't look consistent. In MainChild.js, in the function reload(), for the line "let sites = this.getSites(browser)" it looks like this can get assigned to "sites" when this issue occurs -

Code: Select all

{scriptCount:1, pluginCount:0, pluginExtras:[[]], pluginSites:[], docSites:["moz-extension://<NS embedded webext internal uuid>"], recentlyBlocked:[], all:[], docJSBlocked:false, cspBlocked:false, topSite:"moz-extension://<NS embedded webext internal uuid>"}
But this also can happen when changing permissions of the top-level document, yet that seems to reload fine.

Does any of this help?