[DONE] RFE: Show meaningful error on https-forcing loop

Bug reports and enhancement requests
Post Reply
mattmccutchen
Posts: 9
Joined: Mon Mar 23, 2009 12:26 am

[DONE] RFE: Show meaningful error on https-forcing loop

Post by mattmccutchen »

If an https Web page redirects to the same page via http (e.g., https://www.sciencedirect.com/) but NoScript is forcing https, an infinite loop results. It would be great if this showed a meaningful error message, either the standard redirect-loop message (see bug 83471 and network.http.redirection-limit) or something specific to NoScript.
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.10) Gecko/2009042708 Fedora/3.0.10-1.fc10 Firefox/3.0.10
User avatar
Giorgio Maone
Site Admin
Posts: 9454
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: RFE: Show meaningful error on https-forcing loop

Post by Giorgio Maone »

Thanks for the suggestion, it would be handy indeed.
Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10 (.NET CLR 3.5.30729)
User avatar
Giorgio Maone
Site Admin
Posts: 9454
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: RFE: Show meaningful error on https-forcing loop

Post by Giorgio Maone »

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10 (.NET CLR 3.5.30729)
User avatar
therube
Ambassador
Posts: 7924
Joined: Thu Mar 19, 2009 4:17 pm
Location: Maryland USA

Re: [DONE] RFE: Show meaningful error on https-forcing loop

Post by therube »

Just to point out, that if the site is removed from Force HTTPS, the Try Again button (at least that's what SeaMonkey shows) remains ineffectual. You must reopen the link in a new tab/window.

Also given that we know the cause of the redirection error, could the notice include the fact that the site is set as Force HTTPS, or some other prompt to remind oneself. Otherwise, you could happen upon the error & not realize (having forgotten) that you had placed the site in Force HTTPS.

Also interesting, if you view-source of the redirection error "message", you do get the actual source of sciencedirect.com.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 Pinball NoScript FlashGot AdblockPlus
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.21) Gecko/20090403 Firefox/2.0 SeaMonkey/1.1.16
User avatar
Giorgio Maone
Site Admin
Posts: 9454
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: [DONE] RFE: Show meaningful error on https-forcing loop

Post by Giorgio Maone »

therube wrote: Also given that we know the cause of the redirection error, could the notice include the fact that the site is set as Force HTTP
This information is logged in the Error Console.
Reusing the standard Gecko redirect loop error allowed for one-shot cross-browser implementation and no need for additional localization effort.
Not to mention that the page giving you the error is the https one, but for this (rare) event to happen you must follow/enter a http URL, therefore the situation is easily discoverable.
Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10 (.NET CLR 3.5.30729)
User avatar
therube
Ambassador
Posts: 7924
Joined: Thu Mar 19, 2009 4:17 pm
Location: Maryland USA

Re: [DONE] RFE: Show meaningful error on https-forcing loop

Post by therube »

Also interesting, if you view-source of the redirection error "message", you do get the actual source of sciencedirect.com.
May have to rethink that. May depend on whether the page had been cached or not?

Hmm. Not sure how I got it to happen? Whatever I did, I got http:/www.sciencedirect.com/ (non-https:) source to display - at least once.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 Pinball NoScript FlashGot AdblockPlus
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.21) Gecko/20090403 Firefox/2.0 SeaMonkey/1.1.16
User avatar
Giorgio Maone
Site Admin
Posts: 9454
Joined: Wed Mar 18, 2009 11:22 pm
Location: Palermo - Italy
Contact:

Re: [DONE] RFE: Show meaningful error on https-forcing loop

Post by Giorgio Maone »

therube wrote:
Also interesting, if you view-source of the redirection error "message", you do get the actual source of sciencedirect.com.
May have to rethink that. May depend on whether the page had been cached or not?
Yes it does. view-source tries to get the page from the cache, unless it's a POST request (in that case it gets replayed).
Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10 (.NET CLR 3.5.30729)
Post Reply