Dang. Missed that completely. That is quite a furball indeed.
Initial testing shows no problems with your approach.
Search found 244 matches
- Thu Jan 20, 2022 11:43 am
- Forum: NoScript Commons Library (NSCL)
- Topic: Using nscl patchWorkers in Firefox
- Replies: 21
- Views: 51072
- Thu Jan 20, 2022 9:16 am
- Forum: NoScript Commons Library (NSCL)
- Topic: Using nscl patchWorkers in Firefox
- Replies: 21
- Views: 51072
Re: Using nscl patchWorkers in Firefox
Pardon my absence. Looking at barbazs problem https://forums.informaction.com/viewtopic.php?f=27&t=26485#p104794 I see that window.frames is not a list of frame elements but list of content windows, which is NOT patched by modifyWindow! So adding: function modifyWindowFramesList(win) { let descr...
- Tue Oct 05, 2021 7:26 am
- Forum: NoScript Support
- Topic: 11.2.11 - Certain sites produce Access Denied Page
- Replies: 7
- Views: 2390
Re: 11.2.11 - Certain sites produce Access Denied Page
dominos.co.uk seems to throw the "Access Denied" for anyone coming from outside of UK. Site is accessible for me through UK based proxy, but didn't test any further as I suspect it works the same way as the vans.co.uk, which is: If you visit the site with javascript disabled, it will set y...
- Wed Aug 25, 2021 11:00 pm
- Forum: NoScript Support
- Topic: NoScript later than 11.4 doesn't work properly for some websites
- Replies: 11
- Views: 3096
Re: NoScript later than 11.4 doesn't work properly for some websites
Looks good, passes tests and author.today seems to work. Thanks!
Though I would prefer not to ever have to dare patchWorkers...
Though I would prefer not to ever have to dare patchWorkers...
- Wed Aug 25, 2021 7:10 pm
- Forum: NoScript Support
- Topic: NoScript later than 11.4 doesn't work properly for some websites
- Replies: 11
- Views: 3096
Re: NoScript later than 11.4 doesn't work properly for some websites
Unfortunately this fix makes things work only because it completely breaks webgl blocking in NS 11.2.12rc2! Pointed out the original bug in https://forums.informaction.com/viewtopic.php?f=10&t=26316#p103952, but lets recap: Working version of modifyGetContext (Sorry, no git pull request yet.): f...
- Wed Jun 16, 2021 6:17 am
- Forum: Metaforum
- Topic: Re: something really nasty happen to code when you post it here (split from t=26348)
- Replies: 2
- Views: 14158
Re: something really nasty happen to code when you post it here (split from t=26348)
The code does not get butchered anymore. Thanks!
- Tue Jun 15, 2021 6:48 am
- Forum: NoScript Development
- Topic: InternalError: Too much recursion
- Replies: 12
- Views: 6858
Re: InternalError: Too much recursion
Not sure why, but something really nasty happen to code when you post it here :( Especially interpolated strings with variables inside get really messed up. Could you please send me as a text file or a link pastebin somewhere on the web, if you really prefer not to create a proper PR on Github? Oh,...
- Tue Jun 15, 2021 6:46 am
- Forum: NoScript Development
- Topic: InternalError: Too much recursion
- Replies: 12
- Views: 6858
Re: InternalError: Too much recursion
Your version seems to work quite well. In hindsight, it was quite unnecessary to try to cram all the patches into one call. Preferring your approach. Of course this means that every patchWindow call creates to a new interception layer around window spawning related stuff, but this shouldn't be an is...
- Sun Jun 13, 2021 1:20 pm
- Forum: NoScript Development
- Topic: InternalError: Too much recursion
- Replies: 12
- Views: 6858
Re: InternalError: Too much recursion
You mean something like this? "use strict"; /** * Injects code into page context in a cross-browser way, providing it * with tools to wrap/patch the DOM and the JavaScript environment * and propagating the changes to child windows created on the fly in order * to prevent the modifications ...
- Thu Jun 10, 2021 6:33 am
- Forum: NoScript Development
- Topic: InternalError: Too much recursion
- Replies: 12
- Views: 6858
Re: InternalError: Too much recursion
patchWindow.js "use strict"; /** * Injects code into page context in a cross-browser way, providing it * with tools to wrap/patch the DOM and the JavaScript environment * and propagating the changes to child windows created on the fly in order * to prevent the modifications to be cancelled...
- Tue Jun 08, 2021 1:26 pm
- Forum: NoScript Development
- Topic: InternalError: Too much recursion
- Replies: 12
- Views: 6858
Re: InternalError: Too much recursion
Was wondering if this would turn out to be a problem... Since the patches should not be detectable (in theory), there is no practical way to tell if a window has been already patched. Which means the patch needs to be applied every time the window is accessed through the methods that need patching. ...
- Mon May 17, 2021 6:00 am
- Forum: NoScript Support
- Topic: [RESOLVED] Ways of entering site in whitelist
- Replies: 6
- Views: 3795
Re: Ways of entering site in whitelist
Unlike aspnetcdn.com, amazonaws.com is TLD like .com or .co.uk (search "public suffix" for more info).
- Fri May 14, 2021 2:03 am
- Forum: NoScript Support
- Topic: Noscript blocking google
- Replies: 10
- Views: 6405
Re: Noscript blocking google
What google does here is that they have one <noscript> tag on the page that first applies a style that hides everything on the page and secondly does a meta redirect to the mobile version of the search page. So if you have javascript disabled and accessibility.blockautorefresh set false, you will ju...
- Wed May 05, 2021 7:51 am
- Forum: NoScript Development
- Topic: proxifying modifyGetContext
- Replies: 4
- Views: 5434
Re: proxifying modifyGetContext
- const getContext = scope[canvas].prototype.getContext; + const CanvasClass = window[canvas]; + const getContext = CanvasClass.prototype.getContext; Unfortunately this change affects the "target" getContext for Proxy which needs to be from page context, otherwise there will be e.g. "...
- Wed May 05, 2021 7:45 am
- Forum: NoScript Development
- Topic: [Done]Feature request: erase stickies
- Replies: 4
- Views: 4608
Re: Feature request: erase stickies
Works nicely. Thanks!