by Giorgio Maone » Sat Dec 28, 2019 10:14 am
This is the intended behavior when the toolbar icon is hidden (e.g. in the Tor Browser's default configuration since version 9).
Unfortunately there's no way for a WebExtension to tell whether the toolbar icon is actually hidden or not; not even by catching an exception when trying to programmatically open its popup: browser.browserAction.openPopup() just silently fails, and in NoScript 11.0.9 and below
you would use the keyboard shortcut or the context menu and nothing happened, which became quite apparent and painful in latest Tor Browser.
Therefore
NoScript 11.0.10rc2 introduces this hack: it sends back a message from the popup if it manages to load, and if this message doesn't arrive within 500ms from trying to open the popup, it loads the UI in a separate window (which should work much like the native popup, even closing automatically when it losts focus and triggering a reload if permissions have been changed).
Now in your case I can see two problems, possibly bugs:
- The separate window seems to be forced unconditionally, even though NoScript's toolbar icon is visible. This might be due to 500ms not being enough in your specific configuration? Could you check on a clean profile with just NoScript installed?
- The UI in the window is not functional. Can you show us some screenshots and/or check for error messages, either in the global browser console (ctrl+shift+J) or in the unfunctional UI window (ctrl+shift+K)?
This is the intended behavior when the toolbar icon is hidden (e.g. in the Tor Browser's default configuration since version 9).
Unfortunately there's no way for a WebExtension to tell whether the toolbar icon is actually hidden or not; not even by catching an exception when trying to programmatically open its popup: browser.browserAction.openPopup() just silently fails, and in NoScript 11.0.9 and below [url=https://github.com/hackademix/noscript/issues/58]you would use the keyboard shortcut or the context menu and nothing happened[/url], which became quite apparent and painful in latest Tor Browser.
Therefore [url=https://github.com/hackademix/noscript/commit/528c8ea57790738564cf42b6fb499bdfd7f2e78a]NoScript 11.0.10rc2 introduces this hack[/url]: it sends back a message from the popup if it manages to load, and if this message doesn't arrive within 500ms from trying to open the popup, it loads the UI in a separate window (which should work much like the native popup, even closing automatically when it losts focus and triggering a reload if permissions have been changed).
Now in your case I can see two problems, possibly bugs:
[list=1]
[*]The separate window seems to be forced unconditionally, even though NoScript's toolbar icon is visible. This might be due to 500ms not being enough in your specific configuration? Could you check on a clean profile with just NoScript installed?
[*]The UI in the window is not functional. Can you show us some screenshots and/or check for error messages, either in the global browser console (ctrl+shift+J) or in the unfunctional UI window (ctrl+shift+K)?
[/list]