detection of demuxed streams change has broken flashblock

[Diceman]

With the new update, Flashgot now interferes with flashblock.

I have traced it back to something being performed in this script that no longer behaves correctly with the new version of flashgot.

blocking this file will allow the video to start, but then blocks comments and other aspects of the site.

[Giorgio Maone]

With the new update, Flashgot now interferes with flashblock.

I have traced it back to something being performed in http://s.ytimg.com/yts/jsbin/www-vfl0Ew ... mon_mod.js that no longer behaves correctly with the new version of flashgot.

blocking this file will allow the video to start, but then blocks comments and other aspects of the site.

What do you mean, exactly by "interfering" (step to reproduce)?
Does downgrading FlashGot actually help?
Does the Error Console (Ctrl+Shift+J) show anything interesting?

[Diceman]

Actually, it wasn't a recent change in flashgot that has caused this, the issue can be reproduced as far back as 1.5.5.7, so it must be a change on youtubes side that is causing flashgot to interfere with flashblock

upon updating to flashgot 1.5.5.7+, youtube is no longer functional so long as flashblock is enabled
The blocked applet icon appears momentarily and then is replaced by a solid black frame

STR
Install flashgot and flashblock
navigate to a video on youtube
the video will appear as the usual flashblock clickable frame but then disappear and look like this


where it should look like




Going back to 1.5.5.6 and the flashblock button appears as normal.

1.5.5.7rc introduced these
+ Youtube signature decoding algorithm (SDA) sniffing
(thanks "user" for patches)
+ Youtube SDA sniffing automatically triggered if
stream checks fail
+ flashgot.media.YouTube.decode_signature_func.auto
preference to control whether SDA sniffing should
be automatic or manual (UI-driven)
x More resilient internal preference setting API

Toggling flashgot.media.YouTube.decode_signature_func.sandbox to false brings back the flashblock clickable frame

[Diceman]

3 errors occur in the error console but only when flashgot.media.YouTube.decode_signature_func.timestamp is set to true

[Guest]

3 errors occur in the error console but only when flashgot.media.YouTube.decode_signature_func.timestamp is set to true

Sorry, I meant flashgot.media.YouTube.decode_signature_func.sandbox;true

turning this off removes the errors and restores the flashblock frame to working.

[Giorgio Maone]

3 errors occur in the error console but only when flashgot.media.YouTube.decode_signature_func.timestamp is set to true

Sorry, I meant flashgot.media.YouTube.decode_signature_func.sandbox;true

turning this off removes the errors and restores the flashblock frame to working.

Thank you. That code has been kindly contributed by "user", a genius of Youtube stuff. I'm checking if sandboxing is really needed from a security standpoint.

[Giorgio Maone]

Oops, looks like the main problem is you using Firefox 13/16. Why?
Could you upgrade to latest ESR (24)?

[user]

The second error message looks odd.
What's in your flashgot.media.YouTube.decode_signature_func preference?
URL of the video?

[Diceman]

Oops, looks like the main problem is you using Firefox 13/16. Why?
Could you upgrade to latest ESR (24)?

I guarantee its got nothing to do with the firefox version, it reproduces in nightly as well.

I use 16 still because of issue 781414

[mitzone]

exact same behaviour on my side also. I created an account just to post this. This was after recent flashgot update.

[Diceman]

Heres the same issue in Nightly

[Diceman]

exact same behaviour on my side also. I created an account just to post this. This was after recent flashgot update.

the 1.5.5.95 update tripped me up as well, but its actually a change on youtubes side - the google+ integration has fluffed up the sandbox, since it goes back all the way to 1.5.5.7 and i know for sure there was no problem back then (and flashblock has not been updated between then and now)

[jlv]

3 errors occur in the error console but only when flashgot.media.YouTube.decode_signature_func.timestamp is set to true

Sorry, I meant flashgot.media.YouTube.decode_signature_func.sandbox;true

turning this off removes the errors and restores the flashblock frame to working.

I came here to the forums looking for a solution to the problem between FlashGot and Flashblock. I hadn't updated the FlashGot plugin in a while, and when I finally did, I found that Youtube videos were getting up by a black box. At this point I'm using FF27.0.1 on Windows 7/64. I went through creating a new FF user profile to see if I could narrow down what was causing Youtube to not work -- I suspected it wasn't Flashblock, since I hadn't updated it at all (I had updated about a dozen other add-ons). I finally narrowed it down to just this two add-ons together.

Anyway, I can get Youtube working again just by setting this:

Code: Select all

flashgot.media.YouTube.decode_signature_func.sandbox:false

I just wanted to report this is still a problem with the latest FlashGot (1.5.5.97).

[user]

I don't know what's happened, but I just looked at 98rc1 and it's missing the fallback code. Merged it again:

Code: Select all

http://rghost.net/private/52959999/da4cd39122fc513311c3ab2bb1137db6

[Giorgio Maone]

I just wanted to report this is still a problem with the latest FlashGot (1.5.5.97).

It should be finally fixed in 1.5.5.98rc2, please confirm, thank you.